fix probes #185
Merged
fix probes #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@amine-errahmani can you please resolve merge conflicts? |
Contributor
Author
|
conflicts resolved |
Member
|
@amine-errahmani Thank u for this contribution. I just left some comments |
Contributor
Author
|
@oben01 i just resolved conflicts again |
Member
|
@amine-errahmani in the review tab |
Member
Contributor
Author
|
dosen't seem like i have access to the review tab, clicking on the link just redirects me to the conversation tab |
oben01
reviewed
Dec 5, 2025
Member
|
@amine-errahmani is it better now ?! |
Contributor
Author
|
yup, updated |
amine-errahmani
force-pushed
the
fix_probes
branch
from
9d13b7d to
3994c87
Compare
Member
|
@amine-errahmani LGTM thanks :) |
Member
|
@amine-errahmani could u please regenerate the documentation before I merged it |
Contributor
Author
|
documentation updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to make the livenessProbe and the readinessProbe get templated directly from the values.
this fixes issue #184